Move test fips configuration to script plugin #57251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the configuration of all test jvms for fips to a script plugin. Fips testing is something very specific to the Elasticsearch build and does not need to be passed on to plugin authors.
mark-vieira
requested changes
May 27, 2020
gradle/fips.gradle
Outdated
| import org.elasticsearch.gradle.testclusters.ElasticsearchCluster | ||
|
|
||
| // Common config when running with a FIPS-140 runtime JVM | ||
| if (Boolean.parseBoolean(System.getProperty("tests.fips.enabled"))) { |
There was a problem hiding this comment.
We should use BuildParams.inFipsJvm here instead.
|
@elasticmachine run elasticsearch-ci/1 |
jrodewig
changed the title
rjernst
added
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
rjernst
added
>refactoring
and removed
Team:Core/Infra
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jun 1, 2020
This commit moves the configuration of all test jvms for fips to a script plugin. Fips testing is something very specific to the Elasticsearch build and does not need to be passed on to plugin authors.
rjernst
added a commit
that referenced
this pull request
Jun 1, 2020
This commit moves the configuration of all test jvms for fips to a script plugin. Fips testing is something very specific to the Elasticsearch build and does not need to be passed on to plugin authors.
rjernst
added a commit
that referenced
this pull request
Jun 1, 2020
This commit moves the configuration of all test jvms for fips to a script plugin. Fips testing is something very specific to the Elasticsearch build and does not need to be passed on to plugin authors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the configuration of all test jvms for fips to a
script plugin. Fips testing is something very specific to the
Elasticsearch build and does not need to be passed on to plugin authors.